Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect AbsolutePath in GetContentRoute #17266

Open
wants to merge 1 commit into
base: contrib
Choose a base branch
from

Conversation

ava3a13
Copy link

@ava3a13 ava3a13 commented Oct 13, 2024

Fixes #16745

Description

Previous implementation did not correctly decode Uri into the string - e.g. 'bar%20nix' into 'bar nix'
Original proposal was to pass contentRoute.AbsolutePath into the Uri.UnescapeDataString function.
Current solution calls to GetAbsolutePathDecoded provided on the Uri instance via the UriExtensions class - meaning that all the unit tests are covered within UriExtensionsTests.

Copy link

github-actions bot commented Oct 13, 2024

Hi there @ava3a13, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Oct 14, 2024

Hello @ava3a13 ,

Thanks a lot for spotting the issue and providing the fix 👍

One of us from the core collaborators team will have a look at it soon 😁

Cheers!

@nul800sebastiaan
Copy link
Member

Thanks @ava3a13, sorry for the delay on this one, we'll get to it!

Just a hint: as you may know, this PR qualifies for Umbraco's Hacktoberfest participation for which you can earn rewards.
If you were to make 1 more contribution in the next few days, would be great to see your contributions qualify! You can do it.. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contentRoute.AbsolutePath not being correctly unescaped
3 participants